Reloop beatmix mapping #12422

uncleeugene · 2023-12-10T21:42:23Z

Reloop Beatmix gen.1 mapping added. Documentation is pulled as well.

This reverts commit 688b5e7.

JoergAtGithub · 2023-12-10T22:30:17Z

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

ronso0

Thank you for this mapping!

I just skimmed through an added some first comments.

Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

res/controllers/Reloop Beatmix.midi.xml

res/controllers/Reloop_Beatmix.js

StartupWMClass added. With this property set now the icon in gnome dock shown properly and it is now possible to pin mixxx app to dock.

Agree. I took this line from some other script i used as a base. Co-authored-by: ronso0 <[email protected]>

Same here, this line is inherited from base script. Co-authored-by: ronso0 <[email protected]>

Readability iprovement Co-authored-by: ronso0 <[email protected]>

Co-authored-by: ronso0 <[email protected]>

…tegration" This reverts commit f1fb010.

uncleeugene · 2023-12-11T07:40:49Z

I've signed the agreement.
Git is giving me hard times :) One have to use it for some time to wrap his head around it. I have pushed another commit in that same branch by mistake, but reverted the commit. sorry about that.
Anyways, i updated all that matters with another push. Is that the proper way to update a pull request by just pushing all the changes?

ronso0 · 2023-12-11T12:29:42Z

Thank you.

That's a good moment to learn about git rebase -i and git push -f. I suggest to rebase onto 2.4 and use the s option to squash all commits into one.

Actually rebasing while a review has been published is not advised, but with this rather small PR I see no issues. If you commit substantial changes later on you commit as usual.

uncleeugene · 2023-12-11T12:45:40Z

That's a good moment to learn about git rebase -i and git push -f. I suggest to rebase onto 2.4 and use the s option to squash all commits into one.

I kinda understand what rebase is about but my understanding of the whole structure of git workflow is loose. So i definitely need to start from very basics :)

ronso0 · 2023-12-11T16:59:41Z

res/controllers/Reloop Beatmix.midi.xml

+            <control>
+                <group>[Master]</group>
+                <key>headGain</key>
+                <status>0xB4</status>
+                <midino>0x51</midino>
+                <options>
+                    <normal/>
+                </options>
+            </control>


Are you sure this does not affect the hardware output? (disable this mapping to double-check)
Just wondering because on my TerminalMix 2 and 4's it does, and they're also from 2012.

I checked it just now by closing headphone out with hardware pot and opening it back with mouse. Since there's just one headphone volume control i assume it is software :) Master is the only hardware control. Well there's mic gain and jog sensitivity trims as well.

mxmilkiib · 2023-12-12T17:10:49Z

The file name convention is to use hyphens instead of spaces.

See also #12333

(I thought I left a comment before but most not have hit enter!)

uncleeugene · 2023-12-12T19:22:30Z

The file name convention is to use hyphens instead of spaces.

See also #12333

(I thought I left a comment before but most not have hit enter!)

Done :)

github-actions · 2024-03-12T00:06:58Z

This PR is marked as stale because it has been open 90 days with no activity.

ronso0 · 2024-03-18T16:38:07Z

res/controllers/Reloop-Beatmix.scripts.js

+    if (control === QUICKJOGR || control === QUICKJOGL) {
+        engine.setValue(group, "jog", newValue/2);
+    } else {
+        engine.setValue(group, "jog", newValue/16);
+    }


What's the reason you have two jog modes, not jog and scratch?
That would free Shift+Load for Eject (currently it's the scratch toggle).
Note that Eject is not purely "eject" in Mixxx 2.4, it also does un-eject and un-overload, see https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[ChannelN]-eject

Btw does holding the 🔍 button affect the jog wheel? Like long-press it and it does not toggle the LED permanently?
Reason I ask is, on the TerminalMix the wheel has three modes, as well:
regular (no touch signal), scratch (touch), search (:mag: hold)

ronso0 · 2024-03-18T16:38:32Z

res/controllers/Reloop-Beatmix.scripts.js

+
+// Beatmix.navKnob handles navigation dial. It will scroll through library.
+Beatmix.navKnob = function(_channel, control, value, _status, _group) {
+    //console.log("control: " + control + ", value: " + value + ", status: " + status);


Is this still needed?

ronso0 · 2024-03-18T16:40:02Z

res/controllers/Reloop-Beatmix.scripts.js

+    }
+};
+
+// Beatmix.loopSize handles Loop Size knob. This know ajusts auto loop size.


Suggested change

// Beatmix.loopSize handles Loop Size knob. This know ajusts auto loop size.

// Beatmix.loopSize handles Loop Size knob. This now adjusts auto loop size.

ronso0 · 2024-03-18T16:40:34Z

res/controllers/Reloop-Beatmix.scripts.js

+Beatmix.loopSize = function(_channel, _control, value, _status, group) {
+    const newValue = value - 64;
+    if (newValue < 0) {
+        engine.setValue(group, "loop_halve", 1);


I suggest to use script.triggerControl(group, control, delay) to release the button.

ronso0 · 2024-03-18T17:01:02Z

res/controllers/Reloop-Beatmix.midi.xml

+                </options>
+            </control>
+            <control>
+                <group>[EffectRack1_EffectUnit1]</group>


I'm not really happy with this since this control has no GUI indicator. (though, units are enabled by default after start)
Also, for On/Off you already have the Mix knob mapped.

Can we use it for something else instead which is not covered, yet?
Press: ON
Shift+Press: OFF

or

Press: toggle Mix between 0 and 1
Shift+Press: toggle Quick Effect

or

Press: un/assign unit1 to deck1
Shift+Press: un/assign unit1 to deck2 / un/assign unit2 to deck1

uncleeugene added 3 commits December 11, 2023 02:17

Reloop Beatmix gen.1 mapping added.

688b5e7

Revert "Reloop Beatmix gen.1 mapping added."

bca8bd8

This reverts commit 688b5e7.

Reloop Beatmix gen.1 mapping added.

692c982

github-actions bot added the controller mappings label Dec 10, 2023

ronso0 requested changes Dec 10, 2023

View reviewed changes

uncleeugene and others added 7 commits December 11, 2023 12:23

A small change in .desktop file in order to fix gnome dock integration

f1fb010

StartupWMClass added. With this property set now the icon in gnome dock shown properly and it is now possible to pin mixxx app to dock.

Update res/controllers/Reloop Beatmix.midi.xml

cc54442

Agree. I took this line from some other script i used as a base. Co-authored-by: ronso0 <[email protected]>

Update res/controllers/Reloop Beatmix.midi.xml

ee03e4c

Same here, this line is inherited from base script. Co-authored-by: ronso0 <[email protected]>

Update res/controllers/Reloop_Beatmix.js

54e97e1

Readability iprovement Co-authored-by: ronso0 <[email protected]>

Update res/controllers/Reloop_Beatmix.js

3c49d62

Co-authored-by: ronso0 <[email protected]>

Revert "A small change in .desktop file in order to fix gnome dock in…

b8be0b3

…tegration" This reverts commit f1fb010.

Mostly cosmetic changes to improve readability.

c0d4c75

One incorrect entry removed from xml file.

e03b0d7

ronso0 mentioned this pull request Dec 11, 2023

A small fix to .desktop file that improves Gnome dock integration on #12424

Merged

ronso0 reviewed Dec 11, 2023

View reviewed changes

ronso0 mentioned this pull request Dec 11, 2023

Reloop Beatmix gen.1 documentation page added. mixxxdj/manual#598

Open

Filenames changed in order to meet file naming convention.

e27da88

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Mar 12, 2024

JoergAtGithub added needs review and removed stale Stale issues that haven't been updated for a long time. labels Mar 16, 2024

JoergAtGithub requested a review from ronso0 March 16, 2024 11:10

ronso0 requested changes Mar 19, 2024

View reviewed changes

ronso0 added this to the 2.4.2 milestone Apr 13, 2024

daschuer removed the needs review label Sep 17, 2024

daschuer marked this pull request as draft September 17, 2024 06:06

daschuer removed this from the 2.4.2 milestone Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reloop beatmix mapping #12422

Reloop beatmix mapping #12422

uncleeugene commented Dec 10, 2023

JoergAtGithub commented Dec 10, 2023

ronso0 left a comment

uncleeugene commented Dec 11, 2023

ronso0 commented Dec 11, 2023 •

edited

Loading

uncleeugene commented Dec 11, 2023

ronso0 Dec 11, 2023

uncleeugene Dec 11, 2023

mxmilkiib commented Dec 12, 2023

uncleeugene commented Dec 12, 2023

github-actions bot commented Mar 12, 2024

ronso0 Mar 18, 2024

ronso0 Mar 18, 2024

ronso0 Mar 18, 2024

ronso0 Mar 18, 2024 •

edited

Loading

ronso0 Mar 18, 2024

	// Beatmix.loopSize handles Loop Size knob. This know ajusts auto loop size.
	// Beatmix.loopSize handles Loop Size knob. This now adjusts auto loop size.

Reloop beatmix mapping #12422

Are you sure you want to change the base?

Reloop beatmix mapping #12422

Conversation

uncleeugene commented Dec 10, 2023

JoergAtGithub commented Dec 10, 2023

ronso0 left a comment

Choose a reason for hiding this comment

uncleeugene commented Dec 11, 2023

ronso0 commented Dec 11, 2023 • edited Loading

uncleeugene commented Dec 11, 2023

ronso0 Dec 11, 2023

Choose a reason for hiding this comment

uncleeugene Dec 11, 2023

Choose a reason for hiding this comment

mxmilkiib commented Dec 12, 2023

uncleeugene commented Dec 12, 2023

github-actions bot commented Mar 12, 2024

ronso0 Mar 18, 2024

Choose a reason for hiding this comment

ronso0 Mar 18, 2024

Choose a reason for hiding this comment

ronso0 Mar 18, 2024

Choose a reason for hiding this comment

ronso0 Mar 18, 2024 • edited Loading

Choose a reason for hiding this comment

ronso0 Mar 18, 2024

Choose a reason for hiding this comment

ronso0 commented Dec 11, 2023 •

edited

Loading

ronso0 Mar 18, 2024 •

edited

Loading