-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing space to engine controller API documentation #14384
Conversation
I think every contributor "started small" but you definitely made a mark here 🤣 Here's the usual paperwork, certainly not for this PR though, but in eager anticipation of more to come ; ) Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. |
Doing my part 🫡
done |
Alright, thanks! What's that Herculse mapping merge all about? |
oh this was because of me not properly understanding how prs work. i just wanted to merge my rmx branch into my main. i had no idea that it would show up here got this old controller recently and wanted to update the mapping. the one in main is for mixxx 1.1. my plan is to improve this really nice 2.1 one i found to turn this oldtimer into a usable controller that's 2.5 ready. it's insanely well manufactured, looks cool and is fairly cheap when bought used. some features just didn't age well; like you can see that this was an early attempt at pioneering (pun intended) into digital djing without really knowing yet what features and layouts make sense and which don't (main vol fader between the deck faders would be one example. try playing a proper set without even touching it. had to tape that thing haha) |
Ah, okay. |
@acolombier No need to review the Hercules mapping, it slipped in here by accident (see convo above) |
Ah I'm sorry for the noise here, jumped to quickly to the |
thanks nonetheless :D |
@13dixi37 please remove the Hercules commits. |
done! sorry for the hassle and thanks for the help <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Welcome to Mixxx community :D
I just imagined the hypothetical scenario where we wanted to distribute Mixxx in the App Store again and couldn't because this was the only contribution where the author didn't sign the CLA 😄 |
guidelines say make commits as small as possible, so here we are
disclaimer:
please bear with me for I have very little experience with coding and this is my very first time contributing on github ever <3