Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a config file #60

Closed
szg251 opened this issue Feb 18, 2022 · 5 comments
Closed

Using a config file #60

szg251 opened this issue Feb 18, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@szg251
Copy link
Collaborator

szg251 commented Feb 18, 2022

I think our PABConfig got a bit bloated with a lot of options that don't necessarily need to be changed.
I would propose a yaml configuration file, but i am open to other options.

@szg251 szg251 added the enhancement New feature or request label Feb 22, 2022
@samuelWilliams99
Copy link
Contributor

@samuelWilliams99
Copy link
Contributor

samuelWilliams99 commented Feb 22, 2022

We should keep both options available though, as sometimes the config needs to be derived from something.

@samuelWilliams99
Copy link
Contributor

Didn't meant to click close there!

@ryukzak
Copy link
Contributor

ryukzak commented Mar 7, 2022

Config file format options (mostly from my experience):

  • yaml -- good for programmers, but horrible for normal people who can use ms notebook, can't distinguish spaces and tabs, don't believe in space meaning.
  • dhall -- high customizable configuration files with embedded template language, as I can see popular in Haskell community, but is overkill for our task and hard to use by normal people.
  • edn -- default config format for clojure, looks good and easy to edit but has too unusual syntax for normal people/admins.
  • A custom format (including what Sam mentioned above) can raise tooling problems. Usage in non-Haskell projects requires parser rewriting, which is not familiar for unix admins.
  • toml -- extension for ini files, so it is a simple and familiar syntax for users.

In conclusion, I would like to try toml, but it is tricky to work with ADT. So I will make a few experiments.

@ryukzak ryukzak mentioned this issue Mar 11, 2022
5 tasks
@ryukzak ryukzak linked a pull request Mar 28, 2022 that will close this issue
5 tasks
@ryukzak ryukzak self-assigned this Mar 28, 2022
@mikekeke
Copy link
Collaborator

Closed by #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants