-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a config file #75
Conversation
d7743f4
to
bd49adf
Compare
Issue: the conflict between Current solution: ignoring. The possible solution for another PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here! Got a lot covered :)
Got quite a few imports here without explicit import lists/qualified - lets get those cleaned up
Also, just to be sure - if we have protocol params file defined, will the protocol params field be populated by reading the file?
Co-authored-by: Samuel Williams <[email protected]>
In the current version - no, but I will fix it as I describe it here: #75 (comment) After that, I would like to update examples to use a config file (only value format) and update readme. |
1d9f326
to
c9c0870
Compare
c9c0870
to
6808161
Compare
Serialization, deserialization, and config description for PABConfig. If nothing is presented -- use default values.
Configuration description:
Default configuration:
What left:
Future work:
protocolParamsFile
andprotocolParams
.BotPlutusInterface.Config.*
in separated package.