updated v2 imports #137
Closed
updated v2 imports #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szg251
reviewed
Aug 1, 2022
src/BotPlutusInterface/CardanoCLI.hs
Outdated
| @@ -70,7 +70,8 @@ import Ledger.Interval ( | |||
| UpperBound (UpperBound), | |||
| ) | |||
| import Ledger.Scripts (Datum, DatumHash (..)) | |||
| import Ledger.Scripts qualified as Scripts | |||
| --import Ledger.Scripts qualified as Scripts | |||
There was a problem hiding this comment.
We can remove the commented line
mikekeke
reviewed
Aug 3, 2022
| @@ -295,7 +295,7 @@ mkDummyPrivateKey (PubKey (LedgerBytes pubkey)) = | |||
| Crypto.xprv $ | |||
| mconcat [dummyPrivKey, dummyPrivKeySuffix, pubkeyBS, dummyChainCode] | |||
|
|
|||
| serialiseScript :: Script -> PlutusScript PlutusScriptV1 | |||
| serialiseScript :: Script -> PlutusScript PlutusScriptV2 | |||
There was a problem hiding this comment.
Will V1 scripts keep working with this change?
There was a problem hiding this comment.
No it won't work with V1. Core things is difference in V1/V2 ScriptContext and validatorHash
|
Thank you for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.