Fix more serialization errors #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmgaray
force-pushed
the
rmgaray/bump-csl-132
branch
4 times, most recently
from
a27b5b4 to
88cc5fe
Compare
The ttl() method is deprecated in CSL because it can throw. This generates problems when extracting the TTL field from a transaction, so it is best to just skip this component.
The transaction with governance actions was re-added after deleting governance actions not supported by conway and hence CDL too.
This reverts commit b651933.
rmgaray
force-pushed
the
rmgaray/bump-csl-132
branch
from
43c0682 to
28af481
Compare
marcusbfs
force-pushed
the
rmgaray/bump-csl-132
branch
from
a2ddd08 to
ca7be56
Compare
itsfarseen
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #29 .
This PR adds a few separate things: