Prepare for publishing on NPM #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmgaray
force-pushed
the
rmgaray/publish-npm
branch
4 times, most recently
from
bfa8731 to
a2b45fb
Compare
itsfarseen
reviewed
Jan 30, 2025
package.json
Outdated
| @@ -21,7 +21,7 @@ | |||
| "build": "npm run codegen && npx tsc && node fix-imports.js", | |||
| "prepare": "npm run build" | |||
| }, | |||
| "author": "", | |||
| "author": "Farseen <[email protected]>", | |||
There was a problem hiding this comment.
I think it's better to replace this with the contributors field. Please add your and marcus's details too.
ref: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#people-fields-author-contributors
itsfarseen
approved these changes
Jan 30, 2025
rmgaray
force-pushed
the
rmgaray/publish-npm
branch
from
a2b45fb to
2f67e34
Compare
rmgaray
force-pushed
the
rmgaray/publish-npm
branch
from
6f24c33 to
6d340c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.