Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env_var and command_line from options #1240

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Remove env_var and command_line from options #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
314dcea
Refactor Options
wks Nov 28, 2024
b17d14e
Revert changes to mmtk and memory_manager
wks Nov 30, 2024
3121ef4
More minor changes
wks Nov 30, 2024
8941384
Do not panic when reading from env var
wks Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mmtk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ impl MMTKBuilder {

/// Set an option.
pub fn set_option(&mut self, name: &str, val: &str) -> bool {
self.options.set_from_command_line(name, val)
self.options.set_by_string(name, val)
}

/// Set multiple options by a string. The string should be key-value pairs separated by white spaces,
/// such as `threads=1 stress_factor=4096`.
pub fn set_options_bulk_by_str(&mut self, options: &str) -> bool {
self.options.set_bulk_from_command_line(options)
self.options.bulk_set_by_string(options)
}

/// Custom VM layout constants. VM bindings may use this function for compressed or 39-bit heap support.
Expand Down
Loading
Loading