-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic v2 Migration #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good. Just a couple of general things:
-
Why are we using typing_extensions instead of typing? The canonical module is
typing
;typing_extensions
is a non-standard package. If we do want to use typing_extensions, then we need to add it to the dependencies in pyproject.toml -
In the future this could maybe be split into a couple of different PRs - one for updating dependencies and fixing breaking changes, one for changing the config from MappingProxyType to ConfigDict, etc, and maybe a separate PR just for updating the test cache.
It's all part of the same upgrade, doesn't make sense for me to split it. |
@evanderiel @HRashidi I've updated the submodule for Mobius Pipeline and merged the main branch. Please, take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Summary:
This PR migrates the codebase to Pydantic >= 2.0.
Key Changes:
Related Issues: #49, #35