Fixed compile error for FirebaseJsonArray remove.

mobizt · Mar 4, 2022 · b1d1231 · b1d1231
1 parent 971ff7b
commit b1d1231
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 37 deletions.
diff --git a/README.md b/README.md
@@ -3,7 +3,7 @@
 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.4390794.svg)](https://doi.org/10.5281/zenodo.4390794)
 
 
-Google's Firebase Realtime Database Arduino Library for ESP8266 v3.9.4
+Google's Firebase Realtime Database Arduino Library for ESP8266 v3.9.5
 
 
 This library supports ESP8266 MCU from Espressif. The following are platforms in which libraries are also available.
@@ -1773,7 +1773,4 @@ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
-CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-
-![](/media/images/stop.svg)
+CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
   "name": "Firebase ESP8266 Client",
-  "version": "3.9.4",
+  "version": "3.9.5",
   "keywords": "communication, REST, esp8266, arduino",
   "description": "The secure, fast and reliable Firebase Realtime database library to read, store, update, delete, listen, backup, and restore data. You can also read and modify the database security rules with this library.",
   "repository": {

diff --git a/library.properties b/library.properties
@@ -1,6 +1,6 @@
 name=Firebase ESP8266 Client
 
-version=3.9.4
+version=3.9.5
 
 author=Mobizt
 

diff --git a/media/images/stop.svg b/media/images/stop.svg
diff --git a/src/FirebaseESP8266.h b/src/FirebaseESP8266.h
@@ -1,15 +1,15 @@
 
 #ifndef FIREBASE_CLIENT_VERSION
-#define FIREBASE_CLIENT_VERSION "3.9.4"
+#define FIREBASE_CLIENT_VERSION "3.9.5"
 #endif
 
 /**
- * Google's Firebase Realtime Database Arduino Library for ESP8266, v3.9.4
+ * Google's Firebase Realtime Database Arduino Library for ESP8266, v3.9.5
  *
- * Created March 1, 2022
+ * Created March 5, 2022
  *
  *   Updates:
- * - Fixed legacy token authentication issue.
+ * - Fixed compile error for FirebaseJsonArray remove.
  *
  *
  * This library provides ESP8266 to perform REST API by GET PUT, POST, PATCH, DELETE data from/to with Google's Firebase database using get, set, update

diff --git a/src/README.md b/src/README.md
@@ -1,7 +1,7 @@
 # Firebase Realtime Database Arduino Library for ESP8266
 
 
-Google's Firebase Realtime Database Arduino Library for ESP8266 v3.9.4
+Google's Firebase Realtime Database Arduino Library for ESP8266 v3.9.5
 
 
 

diff --git a/src/json/FirebaseJson.cpp b/src/json/FirebaseJson.cpp
@@ -1,9 +1,9 @@
 /*
- * FirebaseJson, version 2.6.13
+ * FirebaseJson, version 2.6.14
  *
  * The Easiest Arduino library to parse, create and edit JSON object using a relative path.
  *
- * Created February 28, 2022
+ * Created March 5, 2022
  *
  * Features
  * - Using path to access node element in search style e.g. json.get(result,"a/b/c")

diff --git a/src/json/FirebaseJson.h b/src/json/FirebaseJson.h
@@ -1,9 +1,9 @@
 /*
- * FirebaseJson, version 2.6.13
+ * FirebaseJson, version 2.6.14
  *
  * The Easiest Arduino library to parse, create and edit JSON object using a relative path.
  *
- * Created February 28, 2022
+ * Created March 5, 2022
  *
  * Features
  * - Using path to access node element in search style e.g. json.get(result,"a/b/c")
@@ -46,7 +46,14 @@
 #undef max
 #endif
 #if __has_include(<FS.h>)
+
+#if defined(ESP8266)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
+
 #include <FS.h>
+
 #define MB_JSON_FS_H
 #endif
 #endif
@@ -2032,9 +2039,9 @@ class FirebaseJsonArray : public FirebaseJsonBase
     auto dataRemoveHandler(T arg) -> typename MB_ENABLE_IF<is_string<T>::value, bool>::type
     {
         uint32_t addr = 0;
-        mRemove(getStr(arg, addr));
+        bool ret = mRemove(getStr(arg, addr));
         delAddr(addr);
-        return *this;
+        return ret;
     }
 
     template <typename T>