Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scheduler option to autorun and reaction #979

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 27, 2023

Describe the changes proposed in this Pull Request.

Add scheduler to reaction and autorun to allow customizing the scheduler used to schedule the reaction.

https://mobx.js.org/reactions.html#scheduler-_autorun-reaction_


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 27, 2023

‼️ Deploy request for mobx rejected.

Name Link
🔨 Latest commit 3eca215

@amondnet amondnet force-pushed the 977-feat-add-scheduler-option-to-autorun-and-reaction branch from ba2eb68 to 3eca215 Compare December 27, 2023 07:14
@amondnet amondnet self-assigned this Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00fe8b0) 99.00% compared to head (3eca215) 99.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          57       57           
  Lines        2017     2017           
=======================================
  Hits         1997     1997           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.56% <100.00%> (ø)
mobx_codegen 100.00% <ø> (ø)
mobx_lint ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mobx/lib/src/api/reaction.dart 100.00% <ø> (ø)
mobx/lib/src/core/reaction_helper.dart 96.36% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fe8b0...3eca215. Read the comment docs.

@amondnet amondnet force-pushed the 977-feat-add-scheduler-option-to-autorun-and-reaction branch 3 times, most recently from f68f6f8 to 45316a7 Compare July 14, 2024 04:08
@amondnet amondnet marked this pull request as ready for review July 14, 2024 04:17
@amondnet amondnet force-pushed the 977-feat-add-scheduler-option-to-autorun-and-reaction branch from 45316a7 to 08c1ad7 Compare July 16, 2024 07:50
@amondnet amondnet force-pushed the 977-feat-add-scheduler-option-to-autorun-and-reaction branch from 08c1ad7 to 1172b5e Compare October 28, 2024 01:28
@amondnet amondnet requested review from pavanpodila and fzyzcjy and removed request for pavanpodila and fzyzcjy October 28, 2024 01:28
@amondnet
Copy link
Collaborator Author

amondnet commented Oct 30, 2024

@pavanpodila @fzyzcjy Could you please review the code?

@amondnet amondnet force-pushed the 977-feat-add-scheduler-option-to-autorun-and-reaction branch from 1172b5e to 5dfcd24 Compare October 30, 2024 19:19
Copy link
Member

@pavanpodila pavanpodila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavanpodila
Copy link
Member

I would suggest adding to the Docs as well...its probably a bit stale with the host of changes that have happened in the last year

@pavanpodila
Copy link
Member

Great work btw... @amondnet !

@amondnet amondnet merged commit 9ae8461 into mobxjs:main Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants