-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scheduler option to autorun and reaction #979
feat: add scheduler option to autorun and reaction #979
Conversation
|
Name | Link |
---|---|
🔨 Latest commit | 3eca215 |
ba2eb68
to
3eca215
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 57 57
Lines 2017 2017
=======================================
Hits 1997 1997
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
f68f6f8
to
45316a7
Compare
45316a7
to
08c1ad7
Compare
08c1ad7
to
1172b5e
Compare
@pavanpodila @fzyzcjy Could you please review the code? |
1172b5e
to
5dfcd24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would suggest adding to the Docs as well...its probably a bit stale with the host of changes that have happened in the last year |
Great work btw... @amondnet ! |
Describe the changes proposed in this Pull Request.
Add
scheduler
toreaction
andautorun
to allow customizing the scheduler used to schedule the reaction.https://mobx.js.org/reactions.html#scheduler-_autorun-reaction_
Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changemelos run set_version
command from the root directory