Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: require jsdoc 4.x #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat!: require jsdoc 4.x #19

wants to merge 3 commits into from

Conversation

voxpelli
Copy link
Member

@voxpelli voxpelli commented Aug 5, 2024

Fixes #18

As mentioned in the JSDoc 4.0.0 release notes, it no longer depends on taffydb, and I made the needed changes here.

4.0.0 (November 2022)

@voxpelli voxpelli requested a review from a team August 5, 2024 16:05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕 there are a lot of formatting changes to this that make it hard to review. Would you be up for splitting those out? Or just committing them to main and then merging/rebasing this branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, this is prettier that autoapplied the formatting, the only change I did was the import at the very top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull in updates from clenemt/docdash
2 participants