Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esm-utils.js #5160

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

musanmaz
Copy link

Fix CommonJS named export error in esm-utils (Issue #5156)

This PR addresses the issue described in #5156, where a named export error occurs with CommonJS modules. The following changes have been made:

  • Modified formattedImport function in esm-utils.js to ensure proper handling of CommonJS module imports.
  • Updated requireOrImport to use dealWithExports for CommonJS modules.

Fix CommonJS named export error in esm-utils (Issue mochajs#5156)
Copy link

CLA Missing ID CLA Not Signed

@Uzlopak
Copy link
Member

Uzlopak commented Jun 19, 2024

I dont see the changes you mention in your original post

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft July 3, 2024 16:06
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 the linked issue isn't accepting PRs, so we can't take this PR in. You can read more about this in our .github/CONTRIBUTING.md file. Marking as a draft in the meantime.

FWIW I think this fix makes sense if we can have a clean reproduction on the issue... though we will also need a test to validate it actually fixes the issue. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants