Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump yargs to 17 #5165

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: bump yargs to 17 #5165

wants to merge 3 commits into from

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 2, 2024 •
edited
Loading

PR Checklist

Overview

Bumps yargs and related packages to their latest versions:

  • yargs: from 16.2.0 to 17.7.2
  • yargs-parser: from 20.2.9 to 21.1.1

Both still support Node >= 12.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 2, 2024 16:27
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 2, 2024 16:28
@JoshuaKGoldberg JoshuaKGoldberg added the semver-minor implementation requires increase of "minor" version number; "features" label Jul 3, 2024
voxpelli
voxpelli requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seems to claim that this is failing

Will be easier to figure out why once #5177 is fixed, as then we will no longer fail-fast in the matrix

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft July 20, 2024 16:25
@Uzlopak Uzlopak self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voxpelli voxpelli voxpelli requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Uzlopak Uzlopak

Labels
semver-minor implementation requires increase of "minor" version number; "features"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔒 Security: Upgrade yargs-parser and yargs to latest stable version
3 participants
@JoshuaKGoldberg @voxpelli @Uzlopak