🔨 Refactor(#191): 오류 메시지 상수 추가 함수 기능 분리

modern-agile-team · Feb 28, 2025 · c251281 · c251281
1 parent b7c524d
commit c251281
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 23 deletions.
diff --git a/src/features/user/constants.ts b/src/features/user/constants.ts
@@ -7,3 +7,10 @@ export const OPINIONS_OPTIONS = [
   { label: '기능 추가', id: 2 },
   { label: '직접 입력', id: 3 },
 ] as const;
+
+export const ERROR_MESSAGES = {
+  REQUIRED_CONTENT: '내용은 필수 입력 사항입니다.',
+  CONTENT_TOO_LONG: '내용은 255자 이하로 입력해주세요.',
+  REQUIRED_TITLE: '제목을 입력해주세요.',
+  REQUIRED_QUIZ: '퀴즈를 선택해주세요.',
+} as const;
diff --git a/src/features/user/ui/OpinionsModal.tsx b/src/features/user/ui/OpinionsModal.tsx
@@ -2,7 +2,7 @@ import SortDropdown from '@/common/layout/SortDropdown';
 import Select from '@/features/intro/ui/Select';
 import { useLocationQuizState } from '@/features/quiz/hooks';
 import { Quiz } from '@/features/quiz/types';
-import { OPINIONS_OPTIONS } from '@/features/user/constants';
+import { ERROR_MESSAGES, OPINIONS_OPTIONS } from '@/features/user/constants';
 import { useUserOpinionsQuery } from '@/features/user/queries';
 import {
   ContentWrapper,
@@ -37,35 +37,49 @@ export default function OpinionsModal({
 
   const { mutate: createOpinions } = useUserOpinionsQuery.createOpinions();
 
-  const handleSubmit = () => {
+  const getTitle = () => {
+    const titleMap: Record<string, string> = {
+      '직접 입력': customTitle,
+      퀴즈: quizInfo,
+    };
+
+    return titleMap[selectedOption] || selectedOption;
+  };
+
+  const getErrorMessage = () => {
     if (!content) {
-      setError('내용은 필수 입력 사항입니다.');
-      return;
+      return ERROR_MESSAGES.REQUIRED_CONTENT;
     }
     if (content.length >= 255) {
-      setError('내용은 255자 이하로 입력해주세요.');
-      return;
+      return ERROR_MESSAGES.CONTENT_TOO_LONG;
     }
 
-    if (selectedOption === '직접 입력') {
-      if (!customTitle) {
-        setError('제목을 입력해주세요.');
-        return;
-      }
-    } else if (selectedOption === '퀴즈') {
-      if (!quizInfo) {
-        setError('퀴즈를 선택해주세요.');
-        return;
-      }
+    if (selectedOption === '직접 입력' && !customTitle) {
+      return ERROR_MESSAGES.REQUIRED_TITLE;
+    }
+
+    if (selectedOption === '퀴즈' && !quizInfo) {
+      return ERROR_MESSAGES.REQUIRED_QUIZ;
     }
-    let title = '';
-    if (selectedOption === '직접 입력') {
-      title = customTitle;
-    } else if (selectedOption === '퀴즈') {
-      title = quizInfo;
-    } else {
-      title = selectedOption;
+
+    return null;
+  };
+
+  const validation = () => {
+    const errorMessage = getErrorMessage();
+
+    if (errorMessage) {
+      setError(errorMessage);
+      return false;
+    }
+    return true;
+  };
+
+  const handleSubmit = () => {
+    if (!validation()) {
+      return;
     }
+    const title = getTitle();
 
     createOpinions(
       {