Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set type to commonjs in config-loader package.json #2794

Merged
merged 3 commits into from
Aug 30, 2024
Merged

chore: set type to commonjs in config-loader package.json #2794

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc346ee
chore: disable experimental module syntax detection in test
web-padawan Aug 29, 2024
39229bb
chore: set type to commonjs in package.json
web-padawan Aug 30, 2024
a04ff38
chore: add changeset
web-padawan Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/config-loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"scripts": {
"build": "tsc",
"test:node": "mocha test/**/*.test.js --reporter dot",
"test:node": "mocha test/**/*.test.js --reporter dot --no-experimental-detect-module",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this roughly the same as adding a "type": "commonjs" entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, adding "type": "commonjs" works too. I can add it if you think it's a better solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure where this package fits in the ecosystem, but doing so would prevent any consumers from having a similar issue, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Westbrook The package is used by @web/dev-server and @web/test-runner to load respective configs.

Updated to use "type": "commonjs" and added a changeset. I think it's fine to use patch release for this.

"test:watch": "mocha test/**/*.test.js --watch --watch-files .,src,test --reporter dot"
},
"files": [
Expand Down
Loading