dev-server-core/WebSocketsManager
: send periodic ping over WebSockets to prevent connection closure for inactivity
#2821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
1006
) when testing on BrowserStack (Safari).I couldn't get to the bottom of what exactly is causing the timeout, but sending periodic ping messages fixes it. I checked if the
ws
server is closing the connection, but it doesn't seem to be the case; using a ping to keep the connection alive is suggested here.