-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change alert parts calculations #1084
refactor: change alert parts calculations #1084
Conversation
ATTENTION: - slack tests failed - need to refactor tg message formatter
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
===========================================
- Coverage 66.85% 52.64% -14.21%
===========================================
Files 219 287 +68
Lines 12778 16593 +3815
===========================================
+ Hits 8543 8736 +193
- Misses 3684 7303 +3619
- Partials 551 554 +3 ☔ View full report in Codecov by Sentry. |
Build and push Docker images with tag: 2024-10-23.ae27338 |
Change the rule for calculating alert parts if they are too big
There is no limits on tag length and tags count, so users can use a lot of long tags. In such case the function that resizes alert parts got bad data, which results to wrong calculations and panic in notifier.
This PR offers new function for resizing alert parts. Now the space is distributed between tags, trigger description and events block. If possible, space is given to description and events.
This PR affects the following senders: