feat: Added handling of Remote Unavailable error #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
from
ddfc280
to
73b67b7
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-handling
branch
2 times, most recently
from
3f20693
to
026e69a
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
from
73b67b7
to
0bc0ee5
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-handling
branch
from
026e69a
to
5f0678a
Compare
Codecov Report
@@ Coverage Diff @@
## feature/graphite-unavailability-retriable-calls #765 +/- ##
===================================================================================
+ Coverage 70.94% 71.11% +0.17%
===================================================================================
Files 177 177
Lines 9157 9160 +3
===================================================================================
+ Hits 6496 6514 +18
+ Misses 2283 2268 -15
Partials 378 378
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
from
0bc0ee5
to
bcc4b92
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-handling
branch
2 times, most recently
from
c5b979e
to
1383c1b
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
from
bcc4b92
to
c694629
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
from
c694629
to
a326352
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-handling
branch
from
1383c1b
to
88feba3
Compare
kissken
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
from
a326352
to
19f04a9
Compare
kissken
reviewed
Aug 24, 2022
kissken
reviewed
Aug 24, 2022
kissken
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR slightly changes handling of Remote API errors:
ErrRemoteTriggerResponseandErrRemoteUnavailablenow switch trigger state to EXCEPTION inevitablyErrRemoteUnavailableerror:Remote server unavailable. Trigger is not checked for %d secondsScreenshots
Trigger target error:
Remote unavailable error: