Fixed cluster-specific tests #779
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimedrolity
force-pushed
the
feature/fix-cluster-tests
branch
3 times, most recently
from
2ae9e36
to
38da6f8
Compare
There was double adding data to DB, because nested Convey run twice (example in docs https://github.com/smartystreets/goconvey/blob/master/convey/isolated_execution_test.go#L51). Fixed it by moving code block outside.
In case of Redis cluster, keys are distributed by nodes, so need to count keys from all masters. Added keys counting for all master nodes of cluster.
In case of Redis cluster, keys are distributed by nodes, so need to count keys from all masters. Added keys counting for all master nodes of cluster.
Dimedrolity
force-pushed
the
feature/fix-cluster-tests
branch
from
38da6f8
to
18f1c59
Compare
Dimedrolity
changed the title
|
Converted to draft because we can't test "cli" service right now |
|
In future need to merge feature/refactor-redis-cluster in feature/fix-cluster-tests to DRY in tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 4 failed tests on Redis cluster (it were succesful on local standalone Redis). I fixed 3 tests, one test named TestCluster need to discuss. Also there is many repeating code, need to refactor after merge this PR