Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mojaloop/#3400): benchmarking performance for ALS #1

Merged
merged 39 commits into from
Aug 4, 2023
Merged

feat(mojaloop/#3400): benchmarking performance for ALS #1

merged 39 commits into from
Aug 4, 2023

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Jul 26, 2023 •
edited
Loading

feat(mojaloop/#3400): benchmarking performance for ALS - mojaloop/project#3400

  • created documentation, and scenarios for characterizing ALS
  • documented performance data from ALS characterization runs

feat(mojaloop/#3424): analyse als perf results - mojaloop/project#3424

  • Added analysis for scenarios 1-16

@mdebarros mdebarros mentioned this pull request Jul 17, 2023
Closed
11 tasks
mdebarros and others added 25 commits July 26, 2023 18:48
@mdebarros
updates
4d8649e
@mdebarros
added exports for test-scenarios
54713b7
@mdebarros
added environment
2ef7855
@mdebarros
added log files
35c8fd3
@mdebarros
added test scenario s5-1690447500991
dda6de3
@mdebarros
added data to s5-1690447500991
c4fc6c8
@mdebarros
added 20230727/s7-1690407403663
89cd047
@mdebarros
moved s7-1690407403663/ to 20230726 folder
e6b3edd
@vijayg10
feat: added two scenarios
5128fb1
@mdebarros
updates to main readme, and template
f8d84c7
@vijayg10
feat: added s9 scenario results
2b37a12
@vijayg10
Merge branch 'feat/performance-maintenance-characterisation-als' of h…
7fbce24 
…ttps://github.com/mojaloop/ml-perf-characterization into feat/performance-maintenance-characterisation-als
@mdebarros
added more test-cases
1d697ba
@kleyow
chore: add test results for #11-13
5e86192
@kleyow
chore: remove
cf88741
@mdebarros
fleshed out main readme with approach, and added drawio diagrams
1d79c2a
@mdebarros
fleshed out main readme with approach, and added drawio diagrams
990fe64
@mdebarros
fleshed out main readme with approach, and added drawio diagrams
f7f0d20
@mdebarros
fleshed out main readme with approach, and added drawio diagrams
9249293
@vijayg10
feat: captured s14 data
4e4fe59
@vijayg10
Merge branch 'feat/performance-maintenance-characterisation-als' of h…
1daa63d 
…ttps://github.com/mojaloop/ml-perf-characterization into feat/performance-maintenance-characterisation-als
@mdebarros
added docker version
e5c63d9
@mdebarros
Merge branch 'feat/performance-maintenance-characterisation-als' of g…
a03e42b 
…ithub.com:mojaloop/ml-perf-characterization into feat/performance-maintenance-characterisation-als
@vijayg10
feat: added empty folder structures for s15 and s16 scenarios
c03cd34
@kleyow
chore: add images for s15 and s16
86b3442
@mdebarros mdebarros marked this pull request as ready for review July 31, 2023 13:01
sri-miriyala
sri-miriyala reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sri-miriyala sri-miriyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments around consistency of scenario descriptions.

sri-miriyala
sri-miriyala reviewed Aug 1, 2023
View reviewed changes
sri-miriyala
sri-miriyala reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sri-miriyala sri-miriyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment in the main README for the overall scenarios table.

@mdebarros
feat(mojaloop/#3424): analyse als perf results
6ccdcd6 
feat(mojaloop/#3424): analyse als perf results - mojaloop/project#3424
- Added analysis for scenarios 1-14

feat(mojaloop/#3400): benchmarking performance for als - mojaloop/project#3400
- Updated comments based on PR review.
@mdebarros
Merge branch 'feat/performance-maintenance-characterisation-als' of g…
53b53f7 
…ithub.com:mojaloop/ml-perf-characterization into feat/performance-maintenance-characterisation-als
@mdebarros
feat(mojaloop/#3424): analyse als perf results
f52e52d 
feat(mojaloop/#3424): analyse als perf results - mojaloop/project#3424
- Added analysis for scenarios 15-16
@mdebarros
fixes to headers for consistency
5cf459b
@mdebarros
fixed git.ignore --> .gitignore
cd2f080
sri-miriyala
sri-miriyala approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@sri-miriyala sri-miriyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebarros mdebarros merged commit 2637465 into main Aug 4, 2023
@mdebarros mdebarros mentioned this pull request Aug 4, 2023
Closed
11 tasks
@mdebarros mdebarros deleted the feat/performance-maintenance-characterisation-als branch August 8, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayg10 vijayg10 vijayg10 approved these changes

@sri-miriyala sri-miriyala sri-miriyala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdebarros @vijayg10 @sri-miriyala @kleyow