Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate from babel to SWC #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

momesana
Copy link
Owner

@momesana momesana commented Jun 10, 2023

No description provided.

@momesana momesana requested a review from tindzk June 10, 2023 16:16
@@ -64,18 +64,11 @@ function webpackConfig(_env, { mode = "development" }) {
module: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought webpack was not needed anymore.

Copy link
Owner Author

@momesana momesana Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should webpack not be needed anymore? Webpack is the bundler. Babel which is being replaced here is the transpiler. Once turbopack supports anything other than next.js or swcpack becomes usable, we can switch to those. Until then we are stuck with webpack or vite. Also snowpack is dead.

@@ -1,3 +1,5 @@
node_modules
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing slashes where appropriate (node_modules/, generated/, .swc/ etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants