Synonym sync: Abbreviation exclusions #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
changed the title
- Added abbreviation exclusion rules to config - Updated config name to make more sense in light of this change
joeflack4
force-pushed
the
sync1-synonyms-abbrev-excusions
branch
from
8f1abd4
to
7a085d8
Compare
2 tasks
- Update: outputs
|
@joeflack4 what goal was run to generate the data files in this PR? Did you confirm from the curated examples that the list of synonyms that should not be tagged as an abbreviation are not tagged now? |
joeflack4
commented
Sep 22, 2024
| """Append additional synonym_type(s) based on logical rules.""" | ||
| syn: str = row['synonym'] | ||
| syn_type_str: str = row['synonym_type'] | ||
| types: Set[URI] = set(syn_type_str.split('|') if syn_type_str else []) | ||
|
|
||
| # Acronym: uppercase, no numbers, no whitespace, <10 chars | ||
| if syn.isupper() and not any(char.isspace() for char in syn) and len(syn) < 10: | ||
| if syn not in exclusions and syn.isupper() and not any(char.isspace() for char in syn) and len(syn) < 10: |
There was a problem hiding this comment.
Did you confirm from the curated examples that the list of synonyms that should not be tagged as an abbreviation are not tagged now?
Yep! I checked a few cases in the new v8 google sheet, and they're longer being tagged as such.
There was a problem hiding this comment.
Thanks for the link to the data file. I checked all the ones in the curated file and none are tagged as abbreviations now as expected with this PR.
twhetzel
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #652
Overview
Synonym sync: Abbreviation exclusions
mondo-exclusion-values.yml-->mondo-exclusion-configs.yml: I didn't rename it just mondo-exclusions in order to disambiguate from similarly named SOURCE_exclusions files, which serve the purpose of excluding entire terms. I went with the general 'configs' name, because these exclude a variety of different things now, from exclusion of entire synonyms being added, to exclusion of synonym type axioms.Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
Google sheet