Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mirror_signature-ncit.tsv use component-download instead? #678

Open
joeflack4 opened this issue Oct 6, 2024 · 0 comments
Open

Should mirror_signature-ncit.tsv use component-download instead? #678

joeflack4 opened this issue Oct 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working ncit

Comments

@joeflack4
Copy link
Contributor

Overview

reports/mirror_signature-%.tsv uses component-download-%.owl as a prereq.

But the specific goal for NCIT, reports/mirror_signature-ncit.tsv, uses $(COMPONENTSDIR)/ncit.db as a prereq. That .db uses components/ncit.owl.

So it's not actually a mirror signature; it's a component signature. For example, the components goal for NCIT does remove -T $(TMPDIR)/ncit_relevant_signature.txt --select complement --select "classes individuals" --trim false \.

I'm not sure if this effectively has any ramifications.

Possible solutions

Could change $(COMPONENTSDIR)/ncit.db prereq to tmp/component-download-ncit.owl.db.

@joeflack4 joeflack4 added bug Something isn't working ncit labels Oct 6, 2024
@joeflack4 joeflack4 self-assigned this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ncit
Projects
None yet
Development

No branches or pull requests

1 participant