DOCSP-44856: x509 authentication fixes #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
approved these changes
Feb 19, 2025
| .. tip:: | ||
|
|
||
| To learn more about X.509 certificates, see | ||
| :manual:`X.509 </core/security-x.509/>` in the {+server+} manual. |
There was a problem hiding this comment.
nit: The title has a lowercase "x" in the server manual page
Suggested change
| :manual:`X.509 </core/security-x.509/>` in the {+server+} manual. | |
| :manual:`x.509 </core/security-x.509/>` in the {+server+} manual. |
| @@ -74,13 +74,13 @@ async fn main() -> mongodb::error::Result<()> { | |||
|
|
|||
| // start-x509 | |||
| let uri = format!( | |||
| "mongodb://<hostname>:<port>/?tlsCAFile={tlsCAFile}&tlsCertificateKeyFile={tlsCertificateKeyFile}", | |||
| "mongodb://<hostname>:<port>/?tlsCAFile={tlsCAFile}&tlsCertificateKeyFile={tlsCertificateKeyFile}&tlsCertificateKeyFilePassword={tlsCertificateKeyFilePassword}", | |||
There was a problem hiding this comment.
Can this string be broken up into multiple lines, or will that break the code?
There was a problem hiding this comment.
breaks the code unfortunately :/
There was a problem hiding this comment.
you can do backslash-newline to break up a long string, e.g.
let long_string = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";There was a problem hiding this comment.
Good to know - fixed!
norareidy
requested review from
a team and
isabelatkinson
and removed request for
a team
isabelatkinson
approved these changes
Feb 19, 2025
| @@ -74,13 +74,13 @@ async fn main() -> mongodb::error::Result<()> { | |||
|
|
|||
| // start-x509 | |||
| let uri = format!( | |||
| "mongodb://<hostname>:<port>/?tlsCAFile={tlsCAFile}&tlsCertificateKeyFile={tlsCertificateKeyFile}", | |||
| "mongodb://<hostname>:<port>/?tlsCAFile={tlsCAFile}&tlsCertificateKeyFile={tlsCertificateKeyFile}&tlsCertificateKeyFilePassword={tlsCertificateKeyFilePassword}", | |||
There was a problem hiding this comment.
you can do backslash-newline to break up a long string, e.g.
let long_string = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
norareidy
added a commit
that referenced
this pull request
Feb 19, 2025
(cherry picked from commit fc77919)
norareidy
added a commit
that referenced
this pull request
Feb 19, 2025
(cherry picked from commit fc77919)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44856
Staging - https://deploy-preview-167--docs-rust.netlify.app/fundamentals/authentication/
Self-Review Checklist