Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: A more captivating error message when genny_core exits non-zero #1222

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wqian94
Copy link
Contributor

@wqian94 wqian94 commented May 16, 2024

Jira Ticket: None

Whats Changed

Add a more captivating error message for when genny_core returns a non-zero exit status code.

Patch Testing Results

N/A

image

@wqian94 wqian94 requested a review from a team as a code owner May 16, 2024 19:38
Copy link
Collaborator

@thessem thessem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually happy to accept this provided:

  • Is not being able to find the stack-traces a real problem people are seeing?
  • Does this look okay on standard terminals with light backgrounds?
  • We cannot use Mario in an open source project given how litigious Nintendo can get about their trademarks.

If this doesn't look like it's going to go anywhere, I'd appreciate this PR being closed or moved to draft. Thanks, and let's a go

@wqian94
Copy link
Contributor Author

wqian94 commented May 20, 2024

These are excellent questions. I personally find this useful, but I'll move the PR into draft mode for now.

@wqian94 wqian94 marked this pull request as draft May 20, 2024 17:19
@wqian94
Copy link
Contributor Author

wqian94 commented May 20, 2024

(Update on one of the above points): The colors seem to render fine on a light background. It's really more of how the terminal's color palette is set up, since colors are highly customizable. Tested mainly on a bunch of built-in palettes in gnome-terminal, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants