Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-5263 Convert s3-related functions to generated config #2259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PYTHON-5263 Convert s3-related functions to generated config #2259

wants to merge 2 commits into from
+332 −143

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from NoahStapp April 2, 2025 21:54
NoahStapp
NoahStapp reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you schedule a patch build that ensures all of these functions don't behave differently than expected?

@blink1073
Copy link
Member Author

Mo Artifacts and upload coverage:

image

Download and merge coverage:

image

We don't actually use the upload working dir anymore.

@blink1073 blink1073 requested a review from NoahStapp April 4, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahStapp NoahStapp Awaiting requested review from NoahStapp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @NoahStapp