SERVER-80231: Add conditional statement for variable declaration #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your comments |
|
Thanks for making this pull request! We just need you to create a new SERVER ticket on JIRA to help us track the PR. Linking https://jira.mongodb.org/browse/CXX-2708 will be great too. |
kelly-cs
changed the title
|
We're changed the existing ticket to SERVER-80231 (originally CXX-2708) to track this work, so no need to make a new ticket. |
Please fix he typos and recommit |
Just fixed. |
|
The mongo codebase isn't intended to be depended upon as a library externally, and there shouldn't be multiple definitions of INVALID_SOCKET internal to mongo. In light of that, I'm going to close this, but thanks for the submission anyways! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes solve the minor issue reported here.