#945509 Support ref readonly parameters #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for correct rendering of "ref readonly" parameter in C# method signature documentation.
nickwalkmsft
force-pushed
the
nickwalk/refreadonlyparams
branch
from
b8d8963
to
a4bac65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item: https://ceapex.visualstudio.com/Engineering/_workitems/edit/945509
Add support for correct rendering of "ref readonly" parameter in C# method signature documentation.
Added one unit test and also verified output against the case mentioned in the work item (https://learn.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.unsafe.asref?view=net-8.0#system-runtime-compilerservices-unsafe-asref-1%28-0@%29 should render with
scoped ref readonly T sourceinstead ofscoped ref T source.I couldn't get the C++ tests running but they appear to be out of scope here.