Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

[release-8.4] Abstracts IPropertyGrid and uses in Preferences to fix a11c issues #9165

Merged
merged 30 commits into from
Oct 31, 2019

Conversation

monojenkins
Copy link
Contributor

NOTES: Proppy doesn't expose any API to allow us remove the toolbar
xamarin/Xamarin.PropertyEditing#663

Also there is an issue in numeric decimal editors in Culture separator symbol non ENGLISH based
xamarin/Xamarin.PropertyEditing#662

Fixes VSTS #1003417 - Replace current F# format preference panel to use native Proppy
Fixes VSTS #1003416 - Replace current XML format preference panel to use native Proppy
Fixes VSTS #1002622 - Add a mechanism outside proppy to hide toolbar
Fixes VSTS #637121 - Accessibility: Preferences - Code Formatting: Unable to access Layout,Refracting,Spacing categorized formattings using keyboard.
Fixes VSTS #637246 - Accessibility: Preferences - Code Formatting F#: Not able to access Attributes,Document,Elements and it’s inside elements under 'Source code -> XML document'.
Fixes VSTS #1001600 - A11Y_Xamarin Designers_Property pane_keyboard : Keyboard is getting trapped at “Automatic tree” check box
Fixes VSTS #1001627 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to open the “Edit” button by using space/enter keys### Preferences CodeFormating XML
Fixes VSTS #1001625 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to check/uncheck the “Automatic tree” check box by using space key

image

Preferences CodeFormating F#

image

Backport of #8937.

/cc @netonjm

@netonjm
Copy link
Contributor

netonjm commented Oct 31, 2019

@monojenkins rebase

1 similar comment
@sevoku
Copy link
Member

sevoku commented Oct 31, 2019

@monojenkins rebase

@monojenkins monojenkins force-pushed the backport-pr-8937-to-release-8.4 branch from ec4e977 to 33c08d8 Compare October 31, 2019 08:44
@monojenkins monojenkins force-pushed the backport-pr-8937-to-release-8.4 branch from 33c08d8 to cf8910e Compare October 31, 2019 10:31
@sevoku sevoku merged commit 1f99337 into release-8.4 Oct 31, 2019
@sevoku sevoku deleted the backport-pr-8937-to-release-8.4 branch October 31, 2019 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants