Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Add Visual Studio 2019 enhanced themes #9375

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoeRobich
Copy link
Contributor

I think themes based on the enhanced colors scheme introduced in VS2019 (dotnet/roslyn#31976) would be a nice addition.

Dark+
image

Light+
image

@sandyarmstrong sandyarmstrong added the Area: VS Text Editor For issues and pull requests concerning the new native Cocoa VS Text Editor in Visual Studio for Mac label Dec 3, 2019
@JoeRobich JoeRobich closed this Dec 9, 2019
@JoeRobich JoeRobich reopened this Dec 9, 2019
@nosami
Copy link
Member

nosami commented Dec 9, 2019

Looks great with F# code too

image

@JoeRobich
Copy link
Contributor Author

JoeRobich commented Dec 9, 2019

Do I need to push this branch to origin so that CI can run? Or does it matter since this isn't a functional change?

@nosami
Copy link
Member

nosami commented Dec 10, 2019

Do I need to push this branch to origin so that CI can run? Or does it matter since this isn't a functional change?

We don't run CI from forks for security reasons. You could request access to the Mono org but I'll create a branch to save some time.

Copy link
Member

@sevoku sevoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not enough to add the json files, we also need to register the resources in the project file, so that the editor and preferences can pick them up. @sandyarmstrong could you help with that?

@JoeRobich
Copy link
Contributor Author

Thanks @sevoku. I think I found the right spot to add them.

@JoeRobich
Copy link
Contributor Author

@sevoku I installed the build produced by the CI. The themes were available from the preferences dialog and worked as expected.

@JoeRobich
Copy link
Contributor Author

@sandyarmstrong Please let me know if there is anything else needed for this PR. =)

@sandyarmstrong
Copy link
Member

@JoeRobich nothing needed from you, thanks. @jmatthiesen was a consensus reached with regard to naming so we can get this merged?

@jmatthiesen
Copy link
Contributor

We're looking at having these replace the default Light and Dark themes, after merging in a few other fixes from the existing Visual Studio Light theme. To clean things up, I think it would be great to merge this work in from the external fork, and then I'll setup a new PR with the next set of changes. @sandyarmstrong, sound good?

Base automatically changed from master to main March 9, 2021 14:17
@akoeplinger akoeplinger changed the base branch from main to master March 15, 2021 17:01
Base automatically changed from master to main March 15, 2021 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: VS Text Editor For issues and pull requests concerning the new native Cocoa VS Text Editor in Visual Studio for Mac
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants