Reduce risk of collision in temp directory creation #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET's GetTempFileName is somewhat prone to collision, per dotnet/runtime#73793 We only use to to "reserve" a name for a directory, but so import the new CreateTempSubdirectoryCore method from .NET 7 and use that, as it fixes the collision issue and removes the extra file creation/deletion steps. This also allows us to tag the temp directories with a "t4 prefix.
mhutch
force-pushed
the
fix-dir-collisions
branch
from
9707c49
to
86c58e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET's GetTempFileName is somewhat prone to collision, per dotnet/runtime#73793
We only use to to "reserve" a name for a directory, but so import the new CreateTempSubdirectoryCore method from .NET 7 and use that, as it fixes the collision issue and removes the extra file creation/deletion steps.
This also allows us to tag the temp directories with a "t4 prefix.