fix: FeesTreasuryProportion is only applied to substrate based tx only #3043
+343
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarekkMA
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2264 KB (no changes) ✅ Moonbeam runtime: 2228 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2264 KB (+236 KB compared to latest release) Moonbeam runtime: 2228 KB (+232 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
|
Hi @TarekkMA, |
|
We still needs tests for it |
Coverage Report@@ Coverage Diff @@
## master tarekkma/fix-fee-treasury-propotion +/- ##
======================================================================
Coverage 79.00% 79.00% 0.00%
Files 305 305
+ Lines 88458 88470 +12
======================================================================
+ Hits 69878 69890 +12
Misses 18580 18580
|
RomarQ
reviewed
Nov 13, 2024
test/suites/dev/moonbase/test-parameters/test-parameters-randomness.ts
Outdated
Show resolved
Hide resolved
RomarQ
reviewed
Nov 13, 2024
test/suites/dev/moonbase/test-parameters/test-parameters-randomness.ts
Outdated
Show resolved
Hide resolved
…mness.ts Co-authored-by: Rodrigo Quelhas <[email protected]>
…mness.ts Co-authored-by: Rodrigo Quelhas <[email protected]>
RomarQ
reviewed
Nov 13, 2024
test/suites/dev/moonbase/test-parameters/test-parameters-runtime.ts
Outdated
Show resolved
Hide resolved
RomarQ
reviewed
Nov 13, 2024
test/suites/dev/moonbase/test-parameters/test-parameters-runtime.ts
Outdated
Show resolved
Hide resolved
RomarQ
reviewed
Nov 13, 2024
test/suites/dev/moonbase/test-parameters/test-parameters-runtime.ts
Outdated
Show resolved
Hide resolved
RomarQ
previously approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Apply
FeesTreasuryProportionto Substate-based txs tips, and Ethereum-based transactions fees.FeesTreasuryProportionvalues.Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?