Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert etcd:list by "/" #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanyarock01
Copy link

If you set an empty etcd prefix / in conf.lua, e.g:

etcd = {
    endpoints = {'http://etcd:2379'},
    prefix = '/',
}

you will get an error like this:

instance      | LuajitError: /instance/.rocks/share/tarantool/config/etcd.lua:148: bad argument #1 to 'sub' (string expected, got nil)

I think we can write an assert for this case.

Logs after:

instance      | LuajitError: /pairdb/.rocks/share/tarantool/config/etcd.lua:194: Failed to list keys by "/", node.key is nil

@ochaton
Copy link
Member

ochaton commented Dec 8, 2022

seems legit

config aims to run tarantool applications (clusters, shards or proxies). normally we need to point user to write proper configuration in ETCD. @vanyarock01 will you update README.md with example of usage for developer and yaml structure of config for devops?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants