Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CMD / CTRL swapping on MacOS #1526

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

soywiz
Copy link

@soywiz soywiz commented Jan 31, 2025

In macOS usually ctrl+c, ctrl+v, ctrl+f and the like are mapped to cmd+c, cmd+v, cmd+f, etc. some apps like Parallels Desktop do this swap too.

This adds an option to allow swapping cmd and ctrl keys.

Right now the option is not translated, and it appears in all the platforms;
we could add this option only on mac but I don't have experience with Qt, so I will need help with that.

Copy link

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition. The control (strg on windows) is usually harder to reach on macOS keyboards and is not used much. It would also be very helpful for games where you could then bind the cmd key which is not possible right now as it is never sent as its considered a system key. This is also why I see no harm here because without the switching the key is simply never send.

I also don't think it doesn't have to be OS specific here. The cmd key is just the windows key. Just adjusting the lable is probably fine (as suggested by me).

We could also change the option to just be: "Sent the left windows/cmd button as strg'. This would already probably be what most people want. You still keep your right windows button.

app/gui/SettingsView.qml Outdated Show resolved Hide resolved
@athei
Copy link

athei commented Feb 6, 2025

BTW there is already a similar PR that was never merged: #1078

But I think swaping with strg is more idiomatic.

Co-authored-by: Alexander Theißen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants