This repository was archived by the owner on Jan 18, 2019. It is now read-only.
Practice corrections #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds jasmine to the env rule in the eslint config file. This is done so that tests don't get false positives for Jasmine-reserved words like "describe", "it", etc.
It was describing the previous test.
delapuente
reviewed
Apr 12, 2017
| @@ -84,7 +84,7 @@ describe('Entities library', function () { | |||
| expect(character.mp).toBe(0); | |||
| expect(character.hp).toBe(0); | |||
| expect(character.maxMp).toBe(0); | |||
| expect(character.maxHp).toBe(15); | |||
There was a problem hiding this comment.
This is not an error, default characters are assigned a minimum maxHp for they to be able to resurrect.
There was a problem hiding this comment.
Oh I see!
I'll remove this commit 👍
Since the word test can have a very specific meaning, it may be better to reword this test description. Also, the presence of two "can" may read a bit repetitive.
octopusinvitro
force-pushed
the
practice-corrections
branch
from
f09727b to
be313f4
Compare
|
@delapuente I have removed the commit and rebased the branch 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am almost finished with the practice in the second chapter and I wanted to let you know that I had so much fun solving it and I learnt a couple of things!
These are some fixes I did as I was going through it.
Thank you for your work 💯