[DISCO-3246] fix: Weather to save normalized city in selected_city field #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiftran
force-pushed
the
bug-selected-city
branch
from
e0bc3a4 to
63f633b
Compare
tiftran
commented
Feb 19, 2025
| @@ -546,7 +546,7 @@ async def _fetch_from_cache( | |||
| """Fetch weather data from cache.""" | |||
| geolocation = weather_context.geolocation | |||
| country = geolocation.country | |||
| city = geolocation.city | |||
| city = weather_context.selected_city | |||
tiftran
commented
Feb 19, 2025
| @@ -11,7 +11,12 @@ | |||
| MaybeStr = Optional[str] | |||
|
|
|||
| LOCALITY_SUFFIX_PATTERN: re.Pattern = re.compile(r"\s+(city|municipality)$", re.IGNORECASE) | |||
| SUCCESSFUL_REGIONS_MAPPING: dict[tuple[str, str], str | None] = {("GB", "London"): "LND"} | |||
| SUCCESSFUL_REGIONS_MAPPING: dict[tuple[str, str], str | None] = { | |||
There was a problem hiding this comment.
Adding the following cities since they require not to have regions and there's a bug with that at the moment
Herraj
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3246
Description
We were saving the manipulated/normalized city name in
geolocation.cityso it changes when we try to fetch from cache, when we try to call the api, we're left with the manipulated/normalized city name with no reference to the originalPR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)