Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCO-3134] Add Steps to CircleCI Workflow Test Jobs For Pushing Test Artifacts to the ETE GCP Cloud Storage #798

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Trinaa
Copy link
Contributor

@Trinaa Trinaa commented Feb 19, 2025

References

JIRA: DISCO-3134

Description

  • add executors to circleci config to address schema validation errors
    • Example:
      image
  • rename unit and integration test artifact files to comply with ETE pipeline specifications
  • add upload test artifact job to main-workflow
  • remove circleci artifact storage to reduce costs
  • remove coverage-combined command, since file is unused

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

* rename unit and integration test artifact files to comply with ETE pipeline specifications
* add upload test artifact job to main-workflow
* remove circleci artifact storage to reduce costs
* remove coverage-combined command, since file is unused

Closes #DISCO-3134
@ncloudioj
Copy link
Contributor

Hey Kat, what do you think about pushing test artifacts from Actions instead from CircleCi? FWIW, we're in the process of migrating away from CircleCI.

@Trinaa
Copy link
Contributor Author

Trinaa commented Feb 20, 2025

Hey Kat, what do you think about pushing test artifacts from Actions instead from CircleCi? FWIW, we're in the process of migrating away from CircleCI.

@ncloudioj I hadn't realized that Git Actions were being using on the main workflow atm. My preference would be to merge this and then migrate it over to Git Actions so that progress on the ETE pipeline isn't blocked. Is that possible?

@Trinaa Trinaa added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 6813e9e Feb 20, 2025
11 checks passed
@Trinaa Trinaa deleted the DISCO-3134 branch February 20, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants