-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISCO-3249] Add IconProcessor utility #810
Conversation
90d9893
to
28ef119
Compare
dde9083
to
78a6f70
Compare
2586471
to
4055e3b
Compare
4055e3b
to
bf3c55e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more comments, we're almost there.
A few more notes for future iterations:
- Would this prevent us from running merino/adm locally? Looks like we can use original_url as fallback when exception occurs, so maybe we're good.
- We need metrics to understand how things perform in the wild.
- As I pointed out the HTTP connection pool, I realized that we could download images concurrently if necessary. Again, metrics will lead us to the better solution.
6bfdec4
to
cdf99cb
Compare
I will follow up with metrics in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! r+wc.
Please add [load test: abort]
to the commit message.
09f1117
to
c1340dc
Compare
c1340dc
to
b5ca1c7
Compare
b5ca1c7
to
864a579
Compare
References
JIRA: DISCO-3249
Description
PR Review Checklist
Put an
x
in the boxes that apply[DISCO-####]
, and has the same title (if applicable)[load test: (abort|skip|warn)]
keywords are applied to the last commit message (if applicable)