[DISCO-3294] chore: update more cities for weather #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiftran
commented
Mar 4, 2025
| @@ -32,7 +32,7 @@ | |||
| "77", | |||
| ), | |||
| ( | |||
| Location(country="AR", regions=["B", "5"], city="La Plata"), | |||
| Location(country="AA", regions=["B", "5"], city="La Plata"), | |||
There was a problem hiding this comment.
Changed this to a fake country code, since as we add more countries to our lists, this test will fail.
There was a problem hiding this comment.
This can be a comment for future reference.
ncloudioj
approved these changes
Mar 4, 2025
| @@ -89,6 +96,11 @@ | |||
| ("US", "UT", "Hill Air Force Base"): 0, | |||
| } | |||
|
|
|||
| KNOWN_SPECIFIC_REGION_COUNTRIES: frozenset = frozenset( | |||
There was a problem hiding this comment.
We're getting constants defined here, let's add some descriptions to them for better readability.
| @@ -32,7 +32,7 @@ | |||
| "77", | |||
| ), | |||
| ( | |||
| Location(country="AR", regions=["B", "5"], city="La Plata"), | |||
| Location(country="AA", regions=["B", "5"], city="La Plata"), | |||
There was a problem hiding this comment.
This can be a comment for future reference.
tiftran
force-pushed
the
update-pathfinder
branch
from
40cff62 to
9e70509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3294
Description
Because we're cycling through city names, normalized city name, city name without locality suffix times # of regions for that city, we're making a lot of requests we don't need to. I've split
REGION_MAPPING_EXCLUSIONSinto two sets instead and added the countries that we know. In addition added the cities in those countries that require the city to be None.PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)