Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO-3308: Add metrics to icon processor and batch processing inside remote settings #824

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

gruberb
Copy link
Member

@gruberb gruberb commented Mar 6, 2025

References

JIRA: DISCO-3308

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

Copy link
Contributor

@misaniwere misaniwere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gruberb gruberb force-pushed the DISCo-3308-icon-metrics branch from 0aaee4a to 1519e47 Compare March 10, 2025 13:13
@gruberb gruberb force-pushed the DISCo-3308-icon-metrics branch 3 times, most recently from d317d14 to 59d9ca5 Compare March 10, 2025 18:38
Copy link
Contributor

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions for your consideration.

@gruberb gruberb force-pushed the DISCo-3308-icon-metrics branch from 59d9ca5 to 784bcd0 Compare March 11, 2025 11:25
@gruberb gruberb force-pushed the DISCo-3308-icon-metrics branch from 784bcd0 to 8ebb40d Compare March 11, 2025 11:31
@gruberb gruberb added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 407d90c Mar 11, 2025
11 checks passed
@gruberb gruberb deleted the DISCo-3308-icon-metrics branch March 11, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants