[DISCO-3209] metrics to include user agent tags #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiftran
commented
Mar 10, 2025
| "Gecko/20100101 Firefox/103.0" | ||
| ), | ||
| }, | ||
| ) | ||
|
|
||
| # TODO: Remove reliance on internal details of aiodogstatsd |
There was a problem hiding this comment.
I'll be attempting to address this TODO as a follow up, since I'm already here 🙂
ncloudioj
approved these changes
Mar 10, 2025
merino/middleware/metrics.py
Outdated
| @@ -39,6 +39,7 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: | |||
| loop = get_event_loop() | |||
| request = Request(scope=scope) | |||
| started_at = loop.time() | |||
| user_agent = scope[ScopeKey.USER_AGENT] | |||
There was a problem hiding this comment.
Nit: let's dump it once here and use the result below. Also, make sure the user agent middleware is ahead of the metrics middleware as scope[ScopeKey.USER_AGENT] is set by the former.
tags = scope[ScopeKey.USER_AGENT].model_dump()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3209
Description
Adding tags to metrics so that we can separate by user agent
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)