Added column for needinfo_user in email template

mozilla · Aug 6, 2024 · 1c83ba3 · 1c83ba3
1 parent 1c07ddd
commit 1c83ba3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/bugbot/rules/inactive_revision.py b/bugbot/rules/inactive_revision.py
@@ -67,7 +67,8 @@ def get_bugs(self, date="today", bug_ids=[], chunk_size=None):
             ]
             if inactive_revs:
                 bug["revisions"] = inactive_revs
-                self._add_needinfo(bugid, inactive_revs)
+                needinfo_user = self._add_needinfo(bugid, inactive_revs)
+                bug["needinfo_user"] = needinfo_user
             else:
                 del bugs[bugid]
 
@@ -80,7 +81,7 @@ def load_template(self, template_filename: str) -> Template:
         template = env.get_template(template_filename)
         return template
 
-    def _add_needinfo(self, bugid: str, inactive_revs: list) -> None:
+    def _add_needinfo(self, bugid: str, inactive_revs: list) -> str:
         has_old_patch = any(
             revision["created_at"] < self.old_patch_limit for revision in inactive_revs
         )
@@ -124,6 +125,8 @@ def _add_needinfo(self, bugid: str, inactive_revs: list) -> None:
                     }
                 ],
             }
+            return nickname
+        return ""
 
     def _find_last_action(self, revision_id):
         details = self._fetch_revisions([revision_id])

diff --git a/templates/inactive_revision.html b/templates/inactive_revision.html
@@ -7,10 +7,11 @@
             <th>Bug</th>
             <th>Summary</th>
             <th>Patches</th>
+            <th>Needinfo Requested</th>
         </tr>
     </thead>
     <tbody>
-        {% for i, (bugid, summary, revisions) in enumerate(data) -%}
+        {% for i, (bugid, summary, revisions, needinfo_user) in enumerate(data) -%}
             <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
             {% endif -%}
             >
@@ -27,6 +28,7 @@
                     {% endfor -%}
                 </ul>
             </td>
+            <td>{{ needinfo_user }}</td>
         </tr>
     {% endfor -%}
 </tbody>