[api-minor] Disable eval support by default

The idea behind this patch is to see if disabling of `eval` leads to any reports about bad performance, since the previous patch should have improved things a fair bit.
mozilla · Mar 5, 2025 · 996c17f · 996c17f
1 parent f6df9f1
commit 996c17f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/display/api.js b/src/display/api.js
@@ -157,7 +157,7 @@ const RENDERING_CANCELLED_TIMEOUT = 100; // ms
  *   Use -1 for no limit, which is also the default value.
  * @property {boolean} [isEvalSupported] - Determines if we can evaluate strings
  *   as JavaScript. Primarily used to improve performance of PDF functions.
- *   The default value is `true`.
+ *   The default value is `false`.
  * @property {boolean} [isOffscreenCanvasSupported] - Determines if we can use
  *   `OffscreenCanvas` in the worker. Primarily used to improve performance of
  *   image conversion/rendering.
@@ -286,7 +286,7 @@ function getDocument(src = {}) {
     Number.isInteger(src.maxImageSize) && src.maxImageSize > -1
       ? src.maxImageSize
       : -1;
-  const isEvalSupported = src.isEvalSupported !== false;
+  const isEvalSupported = src.isEvalSupported === true;
   const isOffscreenCanvasSupported =
     typeof src.isOffscreenCanvasSupported === "boolean"
       ? src.isOffscreenCanvasSupported

diff --git a/web/app_options.js b/web/app_options.js
@@ -408,7 +408,7 @@ const defaultOptions = {
   },
   isEvalSupported: {
     /** @type {boolean} */
-    value: true,
+    value: false,
     kind: OptionKind.API,
   },
   isOffscreenCanvasSupported: {