-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ESLint flat config #19029
Migrate to ESLint flat config #19029
Conversation
70a53f9
to
232288d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
I've not yet tested this locally, but leaving a couple of comments based on a cursory look at the patch.
232288d
to
96dafa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine in local testing, however I've got a couple of minor questions before we land this.
Flat config is the new config system used by ESLint 9. To make the migration easier, they also added flat config support to ESLint 8. This commit migrates the various ESLint configs in the repository to use the new system, **without** upgrading to ESLint 9 yet.
96dafa2
to
9e6ff97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you for implementing this.
Nice work; thank you @nicolo-ribaudo! |
You can see that the right files are being linted with
DEBUG=eslint:flat-eslint npx gulp lint
. I tried playing around in various files and it seems like the right rules are being applied.Ref #17928