Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Make sure the save checkbox isn't focusable when saving is disabled (bug 1952558) #19636

Merged
merged 1 commit into from
Mar 10, 2025
Merged

[Editor] Make sure the save checkbox isn't focusable when saving is disabled (bug 1952558) #19636

merged 1 commit into from
Mar 10, 2025

Conversation

calixteman
Copy link
Contributor

And fix the the width of the warning message when the limit of signatures has been reached: in french the string is longer than the dialog's one.

Snuffleupagus
Snuffleupagus approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/de43ab289723958/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/542194ba63e1f75/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/542194ba63e1f75/output.txt

Total script time: 12.35 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/de43ab289723958/output.txt

Total script time: 27.15 mins

  • Integration Tests: FAILED

@calixteman
[Editor] Make sure the save checkbox isn't focusable when saving is d…
69a2e51 
…isabled (bug 1952558)

And fix the the width of the warning message when the limit of signatures has been reached:
in french the string is longer than the dialog's one.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0aad82bccb40f03/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/36d5f48cfeefe72/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0aad82bccb40f03/output.txt

Total script time: 11.96 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/36d5f48cfeefe72/output.txt

Total script time: 26.80 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit febf59c into mozilla:master Mar 10, 2025
7 checks passed
@calixteman calixteman deleted the bug1952558 branch March 10, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus