osc.lua: don't place the overlay above other ones #15189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
Leaving the z to 0 doesn't work because the order is essentially random. It fails when loading/unloading OSC at runtime. Also with visibility=auto the console can render above the player control, which still responds to mouse despite the console is a layer above. |
When opening select.lua with layout=box and visibility=always, it is drawn below the OSC. Fix it by using z = -1 with visibility always. With bottombar and topbar layouts the console doesn't overlap with the OSC because it reads user-data/osc/margins, so z doesn't matter. This reverts 9c22d6b and 86d24b0.
kasper93
reviewed
Oct 28, 2024
| -- Draw the OSC above the console with visibility auto because the OSC | ||
| -- receives mouse clicks, and below with visibility always because that is | ||
| -- needed with box layout. | ||
| state.osd.z = user_opts.visibility == "auto" and z or -1 |
There was a problem hiding this comment.
I don't understand this condition. Comment is telling that it is needed for box, but it checks visibility?
There was a problem hiding this comment.
IIt's needed for box with visibility always. It is indifferent for bar layouts because they don't overlap thanks to user-data margins. For visibility auto it's more expected to have the OSC on top because it receives clicks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop setting the z of the OSD overlay. This prevents the console from being drawn below the box layout when clicking buttons with visibility=always.
This reverts 9c22d6b and 86d24b0.