Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc display sync fixes #15259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Misc display sync fixes #15259

wants to merge 3 commits into from
+27 −11

Commits on Nov 13, 2024

  1. vo: extract display synced frame end calculation 

    into get_display_synced_frame_end. Used in next commit.
    @llyyr
    llyyr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8791e7b View commit details
    Browse the repository at this point in the history

  2. vo: use display clock to determine frame_end in display synced case

    @llyyr
    llyyr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9c61cf2 View commit details
    Browse the repository at this point in the history

  3. vo: update base_vsync even for initial samples 

    This is still used for caclulating a/v sync and delay remaining even
for initial samples, so we should always update it to the actual vsync
for those initial samples so we have something to work with at least.

And if we receive bogus values, also reset it to 0 along with
prev_vsync.

Not having base_vsync set to _some_ value completely breaks
vsync_skip_detection, and mpv stays stuck in a permanent mistimed state
where every frame is marked as delayed and never recovers from it.
    @llyyr
    llyyr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4c0afdb View commit details
    Browse the repository at this point in the history