console.lua: stop expanding ~/ in file completion #15779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
kasper93
reviewed
Jan 31, 2025
It is not needed to expand ~ in file completion as you type after 62c3aeb made commands themselves interpret it. We only need to call expand-path on the directory before passing it to utils.readdir in order to find files in it when it contains ~ placeholders. As a bonus this will now also complete files in directories like ~~/ and ~state/. This simplifies command completion, and was also the blocker for splitting running commands out of console.lua, since I didn't know how to replicate it through mp.input.
guidocella
force-pushed
the
console-expand
branch
from
d7d93b9 to
bb76253
Compare
Dudemanguy
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed to expand ~ in file completion as you type after 62c3aeb makde commands themselves interpret it. We only need to call expand-path on the directory before passing it to utils.readdir in order to find files in it when it contains ~ placeholders. As a bonus this will now also complete files in directories like ~~/ and ~state/.
This simplifies command completion and was also the blocker for splitting running commands out of console.lua since I didn't know how to replicate it through mp.input.