Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug fix]删除残留的config #27

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[bug fix]删除残留的config #27

wants to merge 1 commit into from
+10 −0

Conversation

cani1see
Copy link

@cani1see cani1see commented Jun 5, 2018

删除残留的config (page json)

@F-loat
Copy link
Member

F-loat commented Jun 6, 2018

是为什么要加这个

@cani1see
Copy link
Author

cani1see commented Jun 6, 2018

@F-loat 之前有配置config 再删除已经生成的.json 还在

@F-loat
Copy link
Member

F-loat commented Jun 6, 2018

那是不是可以去掉 if 的判断，然后改成 const configObj = config ? config.value : {} 这样

@F-loat
Copy link
Member

F-loat commented Jun 6, 2018 •
edited
Loading

这里是不是还有 component 的情况？ 只是 page 和 app 会做这个处理，应该没问题

@cani1see
Copy link
Author

cani1see commented Jun 6, 2018

@F-loat 就是Page有这个问题，生成一堆空json好像不雅吧

@cani1see cani1see closed this Jun 6, 2018
@cani1see cani1see reopened this Jun 6, 2018
@F-loat
Copy link
Member

F-loat commented Jun 6, 2018

那先保持这样，感觉一般页面标题还是会设置的，所以出现这个情况的应该也不多

@cani1see
Copy link
Author

cani1see commented Jun 6, 2018 •
edited
Loading

@F-loat 我们都是用的方法设标题的，因为有几个页面设置了pullrefresh才发现

@weiyunpeng
Copy link

现在的结论是什么？

@anchengjian anchengjian changed the base branch from master to develop August 1, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cani1see @F-loat @weiyunpeng